[ML] Converts index based data visualizer to React#42685
Merged
peteharverson merged 5 commits intoelastic:masterfrom Aug 8, 2019
Merged
[ML] Converts index based data visualizer to React#42685peteharverson merged 5 commits intoelastic:masterfrom
peteharverson merged 5 commits intoelastic:masterfrom
Conversation
peteharverson
requested review from
alvarezmelissa87,
jgowdyelastic,
markov00 and
walterra
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
There was a problem hiding this comment.
Good use of whilst 👍 😆
Contributor
There was a problem hiding this comment.
Assuming these TODOs are going to be done in a follow up?
Contributor
Author
There was a problem hiding this comment.
Yes, using the inline styling of the series color in here and the document count chart will be done in a follow-up. It is awaiting the version of Elastic charts to be bumped to 8.0.0+
Contributor
💚 Build Succeeded |
alvarezmelissa87
approved these changes
Aug 7, 2019
Contributor
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Latest changes LGTM ⚡️
walterra
approved these changes
Aug 7, 2019
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
LGTM, just added a suggestionsabout changing a function to get an array of JSX elements to a React component itself.
Member
There was a problem hiding this comment.
The content of most of the card content components is the same for each card, this could be moved to a common wrapping component to cut down on the duplication.
Contributor
Author
There was a problem hiding this comment.
There is enough variation in the content types that I would prefer to leave this for now, and consider it in a follow-up, for example when looking at switching the file data visualizer to use the same card component as this.
peteharverson
force-pushed
the
ml-data-visualizer-react
branch
from
31da825 to
64a2074
Compare
peteharverson
force-pushed
the
ml-data-visualizer-react
branch
from
64a2074 to
992c67e
Compare
Contributor
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Aug 8, 2019
* [ML] Converts index based data visualizer to React * [ML] Remove unused imports in React data visualizer * [ML] Address review feedback * [ML] Address comments from code review * [ML] Remove redundant ts-ignore
peteharverson
added a commit
that referenced
this pull request
Aug 8, 2019
This was referenced Aug 30, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the index based data visualizer from AngularJS to React.
Functionally there is little change to the previous page. The most significant difference is the addition of a KQL based search bar, so that the page can be opened from a KQL based saved search as well as an index pattern.
If coming in from a lucene based saved search, the search string is displayed in a read-only search field:
The page now uses Elastic charts for charting document count and metric distributions.
See #18374
Note that unit tests will be added in a follow-up.
Checklist
For maintainers